Commit 4a49ae56 authored by Thomas Fourier's avatar Thomas Fourier Committed by Hans Verkuil
Browse files

media: iris: Fix dma_free_attrs() size in iris_hfi_queues_init() 



The core->iface_q_table_vaddr buffer is alloc'd with size queue_size
but freed with sizeof(*q_tbl_hdr) which is different.

Change the dma_free_attrs() size.

Signed-off-by: default avatarThomas Fourier <fourier.thomas@gmail.com>
Reviewed-by: default avatarDikshita Agarwal <dikshita.agarwal@oss.qualcomm.com>
Fixes: d7378f84 ("media: iris: introduce iris core state management with shared queues")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarBryan O'Donoghue <bod@kernel.org>
Signed-off-by: default avatarHans Verkuil <hverkuil+cisco@kernel.org>
parent f27cfdcf

drivers/media/platform/qcom/iris/iris_hfi_queue.c

+1 −1
Original line number Diff line number Diff line
@@ -263,7 +263,7 @@ int iris_hfi_queues_init(struct iris_core *core) 
					  GFP_KERNEL, DMA_ATTR_WRITE_COMBINE);

	if (!core->sfr_vaddr) {

		dev_err(core->dev, "sfr alloc and map failed\n");

		dma_free_attrs(core->dev, sizeof(*q_tbl_hdr), core->iface_q_table_vaddr,

		dma_free_attrs(core->dev, queue_size, core->iface_q_table_vaddr,

			       core->iface_q_table_daddr, DMA_ATTR_WRITE_COMBINE);

		return -ENOMEM;

	}