Commit 4a8f635a authored by Andrii Nakryiko's avatar Andrii Nakryiko Committed by Alexei Starovoitov
Browse files

bpf: remove unnecessary rcu_read_{lock,unlock}() in multi-uprobe attach logic 



get_pid_task() internally already calls rcu_read_lock() and
rcu_read_unlock(), so there is no point to do this one extra time.

This is a drive-by improvement and has no correctness implications.

Acked-by: default avatarJiri Olsa <jolsa@kernel.org>
Signed-off-by: default avatarAndrii Nakryiko <andrii@kernel.org>
Link: https://lore.kernel.org/r/20240521163401.3005045-3-andrii@kernel.org


Signed-off-by: default avatarAlexei Starovoitov <ast@kernel.org>
parent 46ba0e49

kernel/trace/bpf_trace.c

+0 −2
Original line number Diff line number Diff line
@@ -3423,9 +3423,7 @@ int bpf_uprobe_multi_link_attach(const union bpf_attr *attr, struct bpf_prog *pr 
	}



	if (pid) {

		rcu_read_lock();

		task = get_pid_task(find_vpid(pid), PIDTYPE_TGID);

		rcu_read_unlock();

		if (!task) {

			err = -ESRCH;

			goto error_path_put;