Unverified Commit 4ac74ea6 authored by Antheas Kapenekakis's avatar Antheas Kapenekakis Committed by Ilpo Järvinen
Browse files

HID: asus: early return for ROG devices 



Some ROG devices have a new dynamic backlight interface for control by
Windows. This interface does not create an ->input device, causing the
kernel to print an error message and to eject it. In addition, ROG
devices have proper HID names in their descriptors so renaming them is
not necessary.

Therefore, if a device is identified as ROG, early return from probe to
skip renaming and ->input checks.

Acked-by: default avatarBenjamin Tissoires <bentiss@kernel.org>
Reviewed-by: default avatarDenis Benato <benato.denis96@gmail.com>
Signed-off-by: default avatarAntheas Kapenekakis <lkml@antheas.dev>
Link: https://patch.msgid.link/20260122075044.5070-7-lkml@antheas.dev


Reviewed-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
parent 2b92b797

drivers/hid/hid-asus.c

+7 −0
Original line number Diff line number Diff line
@@ -1232,6 +1232,13 @@ static int asus_probe(struct hid_device *hdev, const struct hid_device_id *id) 
	    asus_kbd_register_leds(hdev))

		hid_warn(hdev, "Failed to initialize backlight.\n");



	/*

	 * For ROG keyboards, skip rename for consistency and ->input check as

	 * some devices do not have inputs.

	 */

	if (drvdata->quirks & QUIRK_ROG_NKEY_KEYBOARD)

		return 0;



	/*

	 * Check that input registration succeeded. Checking that

	 * HID_CLAIMED_INPUT is set prevents a UAF when all input devices