Commit 4af52355 authored by Jonas Gorski's avatar Jonas Gorski Committed by Paolo Abeni
Browse files

net: dsa: b53: do not enable RGMII delay on bcm63xx 



bcm63xx's RGMII ports are always in MAC mode, never in PHY mode, so we
shouldn't enable any delays and let the PHY handle any delays as
necessary.

This fixes using RGMII ports with normal PHYs like BCM54612E, which will
handle the delay in the PHY.

Fixes: ce3bf948 ("net: dsa: b53: add support for BCM63xx RGMIIs")
Signed-off-by: default avatarJonas Gorski <jonas.gorski@gmail.com>
Reviewed-by: default avatarFlorian Fainelli <florian.fainelli@broadcom.com>
Link: https://patch.msgid.link/20250602193953.1010487-3-jonas.gorski@gmail.com


Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent 1237c2d4

drivers/net/dsa/b53/b53_common.c

+1 −18
Original line number Diff line number Diff line
@@ -1330,24 +1330,7 @@ static void b53_adjust_63xx_rgmii(struct dsa_switch *ds, int port, 
		off = B53_RGMII_CTRL_P(port);



	b53_read8(dev, B53_CTRL_PAGE, off, &rgmii_ctrl);



	switch (interface) {

	case PHY_INTERFACE_MODE_RGMII_ID:

		rgmii_ctrl |= (RGMII_CTRL_DLL_RXC | RGMII_CTRL_DLL_TXC);

		break;

	case PHY_INTERFACE_MODE_RGMII_RXID:

		rgmii_ctrl &= ~(RGMII_CTRL_DLL_TXC);

		rgmii_ctrl |= RGMII_CTRL_DLL_RXC;

		break;

	case PHY_INTERFACE_MODE_RGMII_TXID:

		rgmii_ctrl &= ~(RGMII_CTRL_DLL_RXC);

		rgmii_ctrl |= RGMII_CTRL_DLL_TXC;

		break;

	case PHY_INTERFACE_MODE_RGMII:

	default:

	rgmii_ctrl &= ~(RGMII_CTRL_DLL_RXC | RGMII_CTRL_DLL_TXC);

		break;

	}



	if (port != dev->imp_port) {

		if (is63268(dev))