Commit 4b2543f7 authored by Hagar Hemdan's avatar Hagar Hemdan Committed by Ard Biesheuvel
Browse files

efi: libstub: only free priv.runtime_map when allocated 



priv.runtime_map is only allocated when efi_novamap is not set.
Otherwise, it is an uninitialized value.  In the error path, it is freed
unconditionally.  Avoid passing an uninitialized value to free_pool.
Free priv.runtime_map only when it was allocated.

This bug was discovered and resolved using Coverity Static Analysis
Security Testing (SAST) by Synopsys, Inc.

Fixes: f80d2604 ("efi: libstub: avoid efi_get_memory_map() for allocating the virt map")
Cc: <stable@vger.kernel.org>
Signed-off-by: default avatarHagar Hemdan <hagarhem@amazon.com>
Signed-off-by: default avatarArd Biesheuvel <ardb@kernel.org>
parent cda30c65

drivers/firmware/efi/libstub/fdt.c

+2 −2
Original line number Diff line number Diff line
@@ -335,7 +335,7 @@ efi_status_t allocate_new_fdt_and_exit_boot(void *handle, 


fail:

	efi_free(fdt_size, fdt_addr);



	if (!efi_novamap)

		efi_bs_call(free_pool, priv.runtime_map);



	return EFI_LOAD_ERROR;