Commit 4b3812d9 authored by Jakub Kicinski's avatar Jakub Kicinski
Browse files

Revert "ptp: Fixes a null pointer dereference in ptp_ioctl" 

This reverts commit 8a4f030d.

Richard says:

  The test itself is harmless, but keeping it will make people think,
  "oh this pointer can be invalid."

  In fact the core stack ensures that ioctl() can't be invoked after
  release(), otherwise Bad Stuff happens.

Fixes: 8a4f030d ("ptp: Fixes a null pointer dereference in ptp_ioctl")
Link: https://lore.kernel.org/all/ZVAf_qdRfDAQYUt-@hoboy.vegasvil.org/


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent c0a2a1b0

drivers/ptp/ptp_chardev.c

+0 −2
Original line number Diff line number Diff line
@@ -176,8 +176,6 @@ long ptp_ioctl(struct posix_clock_context *pccontext, unsigned int cmd, 
	int enable, err = 0;



	tsevq = pccontext->private_clkdata;

	if (!tsevq)

		return -EINVAL;



	switch (cmd) {