Commit 4b7320bf authored by Tvrtko Ursulin's avatar Tvrtko Ursulin Committed by Philipp Stanner
Browse files

drm/sched: Move drm_sched_entity_is_ready to internal header 



Helper is for scheduler internal use so lets hide it from DRM drivers
completely.

At the same time we change the method of checking whethere there is
anything in the queue from peeking to looking at the node count.

Signed-off-by: default avatarTvrtko Ursulin <tvrtko.ursulin@igalia.com>
Cc: Christian König <christian.koenig@amd.com>
Cc: Danilo Krummrich <dakr@kernel.org>
Cc: Matthew Brost <matthew.brost@intel.com>
Cc: Philipp Stanner <phasta@kernel.org>
Signed-off-by: default avatarPhilipp Stanner <phasta@kernel.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20250221105038.79665-5-tvrtko.ursulin@igalia.com
parent b76f1467

drivers/gpu/drm/scheduler/sched_entity.c

+0 −12
Original line number Diff line number Diff line
@@ -151,18 +151,6 @@ static bool drm_sched_entity_is_idle(struct drm_sched_entity *entity) 
	return false;

}



/* Return true if entity could provide a job. */

bool drm_sched_entity_is_ready(struct drm_sched_entity *entity)

{

	if (spsc_queue_peek(&entity->job_queue) == NULL)

		return false;



	if (READ_ONCE(entity->dependency))

		return false;



	return true;

}



/**

 * drm_sched_entity_error - return error of last scheduled job

 * @entity: scheduler entity to check

drivers/gpu/drm/scheduler/sched_internal.h

+13 −0
Original line number Diff line number Diff line
@@ -45,4 +45,17 @@ drm_sched_entity_queue_peek(struct drm_sched_entity *entity) 
	return container_of(node, struct drm_sched_job, queue_node);

}



/* Return true if entity could provide a job. */

static inline bool

drm_sched_entity_is_ready(struct drm_sched_entity *entity)

{

	if (!spsc_queue_count(&entity->job_queue))

		return false;



	if (READ_ONCE(entity->dependency))

		return false;



	return true;

}



#endif

include/drm/gpu_scheduler.h

+0 −1
Original line number Diff line number Diff line
@@ -632,7 +632,6 @@ struct drm_sched_job *drm_sched_entity_pop_job(struct drm_sched_entity *entity); 
void drm_sched_entity_push_job(struct drm_sched_job *sched_job);

void drm_sched_entity_set_priority(struct drm_sched_entity *entity,

				   enum drm_sched_priority priority);

bool drm_sched_entity_is_ready(struct drm_sched_entity *entity);

int drm_sched_entity_error(struct drm_sched_entity *entity);



struct drm_sched_fence *drm_sched_fence_alloc(