Unverified Commit 4b90f16e authored by Jaehun Gou's avatar Jaehun Gou Committed by Konstantin Komarov
Browse files

fs: ntfs3: fix infinite loop in attr_load_runs_range on inconsistent metadata



We found an infinite loop bug in the ntfs3 file system that can lead to a
Denial-of-Service (DoS) condition.

A malformed NTFS image can cause an infinite loop when an attribute header
indicates an empty run list, while directory entries reference it as
containing actual data. In NTFS, setting evcn=-1 with svcn=0 is a valid way
to represent an empty run list, and run_unpack() correctly handles this by
checking if evcn + 1 equals svcn and returning early without parsing any run
data. However, this creates a problem when there is metadata inconsistency,
where the attribute header claims to be empty (evcn=-1) but the caller
expects to read actual data. When run_unpack() immediately returns success
upon seeing this condition, it leaves the runs_tree uninitialized with
run->runs as a NULL. The calling function attr_load_runs_range() assumes
that a successful return means that the runs were loaded and sets clen to 0,
expecting the next run_lookup_entry() call to succeed. Because runs_tree
remains uninitialized, run_lookup_entry() continues to fail, and the loop
increments vcn by zero (vcn += 0), leading to an infinite loop.

This patch adds a retry counter to detect when run_lookup_entry() fails
consecutively after attr_load_runs_vcn(). If the run is still not found on
the second attempt, it indicates corrupted metadata and returns -EINVAL,
preventing the Denial-of-Service (DoS) vulnerability.

Co-developed-by: default avatarSeunghun Han <kkamagui@gmail.com>
Signed-off-by: default avatarSeunghun Han <kkamagui@gmail.com>
Co-developed-by: default avatarJihoon Kwon <kjh010315@gmail.com>
Signed-off-by: default avatarJihoon Kwon <kjh010315@gmail.com>
Signed-off-by: default avatarJaehun Gou <p22gone@gmail.com>
Signed-off-by: default avatarKonstantin Komarov <almaz.alexandrovich@paragon-software.com>
parent fac760f5
Loading
Loading
Loading
Loading
+12 −3
Original line number Diff line number Diff line
@@ -1354,19 +1354,28 @@ int attr_load_runs_range(struct ntfs_inode *ni, enum ATTR_TYPE type,
	CLST vcn;
	CLST vcn_last = (to - 1) >> cluster_bits;
	CLST lcn, clen;
	int err;
	int err = 0;
	int retry = 0;

	for (vcn = from >> cluster_bits; vcn <= vcn_last; vcn += clen) {
		if (!run_lookup_entry(run, vcn, &lcn, &clen, NULL)) {
			if (retry != 0) { /* Next run_lookup_entry(vcn) also failed. */
				err = -EINVAL;
				break;
			}
			err = attr_load_runs_vcn(ni, type, name, name_len, run,
						 vcn);
			if (err)
				return err;
				break;

			clen = 0; /* Next run_lookup_entry(vcn) must be success. */
			retry++;
		}
		else
			retry = 0;
	}

	return 0;
	return err;
}

#ifdef CONFIG_NTFS3_LZX_XPRESS