Commit 4bae7afd authored by Christoph Hellwig's avatar Christoph Hellwig Committed by Jens Axboe
Browse files

paride/pd: remove ->revalidate_disk 



->revalidate_disk is only called during add_disk for pd, but at that
point the driver has already set the capacity to the one returned from
Identify a little earlier, so this additional update is entirely
superflous.

Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Link: https://lore.kernel.org/r/20210308074550.422714-2-hch@lst.de


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent f8d62edf

drivers/block/paride/pd.c

+0 −11
Original line number Diff line number Diff line
@@ -859,16 +859,6 @@ static unsigned int pd_check_events(struct gendisk *p, unsigned int clearing) 
	return r ? DISK_EVENT_MEDIA_CHANGE : 0;

}



static int pd_revalidate(struct gendisk *p)

{

	struct pd_unit *disk = p->private_data;

	if (pd_special_command(disk, pd_identify) == 0)

		set_capacity(p, disk->capacity);

	else

		set_capacity(p, 0);

	return 0;

}



static const struct block_device_operations pd_fops = {

	.owner		= THIS_MODULE,

	.open		= pd_open,
@@ -877,7 +867,6 @@ static const struct block_device_operations pd_fops = { 
	.compat_ioctl	= pd_ioctl,

	.getgeo		= pd_getgeo,

	.check_events	= pd_check_events,

	.revalidate_disk= pd_revalidate

};



/* probing */