Commit 4bc7bc45 authored by Daniel Schaefer's avatar Daniel Schaefer Committed by Jiri Kosina
Browse files

HID: intel-thc-hid: Set HID_PHYS with PCI BDF 

Currently HID_PHYS is empty, which means userspace tools (e.g. fwupd)
that depend on it for distinguishing the devices, are unable to do so.
Other drivers like i2c-hid, usbhid, surface-hid, all populate it.

With this change it's set to, for example: HID_PHYS=0000:00:10.0

Each function has just a single HID device, as far as I can tell, so
there is no need to add a suffix.

Tested with fwupd 2.1.1, can avoid https://github.com/fwupd/fwupd/pull/9995



Cc: Even Xu <even.xu@intel.com>
Cc: Xinpeng Sun <xinpeng.sun@intel.com>
Cc: Jiri Kosina <jikos@kernel.org>
Cc: Benjamin Tissoires <bentiss@kernel.org>
Cc: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: default avatarDaniel Schaefer <git@danielschaefer.me>
Reviewed-by: default avatarEven Xu <even.xu@intel.com>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.com>
parent 1965445e

drivers/hid/intel-thc-hid/intel-quicki2c/quicki2c-hid.c

+1 −0
Original line number Diff line number Diff line
@@ -127,6 +127,7 @@ int quicki2c_hid_probe(struct quicki2c_device *qcdev) 
	hid->product = le16_to_cpu(qcdev->dev_desc.product_id);

	snprintf(hid->name, sizeof(hid->name), "%s %04X:%04X", "quicki2c-hid",

		 hid->vendor, hid->product);

	strscpy(hid->phys, dev_name(qcdev->dev), sizeof(hid->phys));



	ret = hid_add_device(hid);

	if (ret) {

drivers/hid/intel-thc-hid/intel-quickspi/quickspi-hid.c

+1 −0
Original line number Diff line number Diff line
@@ -118,6 +118,7 @@ int quickspi_hid_probe(struct quickspi_device *qsdev) 
	hid->product = le16_to_cpu(qsdev->dev_desc.product_id);

	snprintf(hid->name, sizeof(hid->name), "%s %04X:%04X", "quickspi-hid",

		 hid->vendor, hid->product);

	strscpy(hid->phys, dev_name(qsdev->dev), sizeof(hid->phys));



	ret = hid_add_device(hid);

	if (ret) {