Commit 4bcc0639 authored by Dan Carpenter's avatar Dan Carpenter Committed by Leon Romanovsky
Browse files

ice, irdma: fix an off by one in error handling code 



If we don't allocate the MIN number of IRQs then we need to free what
we have and return -ENOMEM.  The problem is this loop is off by one
so it frees an entry that wasn't allocated and it doesn't free the
first entry where i == 0.

Fixes: 3e0d3cb3 ("ice, irdma: move interrupts code to irdma")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: default avatarTatyana Nikolova <tatyana.e.nikolova@intel.com>
Link: https://patch.msgid.link/20250414234231.523-2-tatyana.e.nikolova@intel.com


Reviewed-by: default avatarMichal Swiatkowski <michal.swiatkowski@linux.intel.com>
Signed-off-by: default avatarLeon Romanovsky <leon@kernel.org>
parent 80f2ab46

drivers/infiniband/hw/irdma/main.c

+1 −1
Original line number Diff line number Diff line
@@ -221,7 +221,7 @@ static int irdma_init_interrupts(struct irdma_pci_f *rf, struct ice_pf *pf) 
			break;



	if (i < IRDMA_MIN_MSIX) {

		for (; i > 0; i--)

		while (--i >= 0)

			ice_free_rdma_qvector(pf, &rf->msix_entries[i]);



		kfree(rf->msix_entries);