Commit 4bd0725c authored by Yu-Chun Lin's avatar Yu-Chun Lin Committed by Jiri Kosina
Browse files

HID: google: fix unused variable warning under !CONFIG_ACPI



As reported by the kernel test robot, the following warning occurs:

>> drivers/hid/hid-google-hammer.c:261:36: warning: 'cbas_ec_acpi_ids' defined but not used [-Wunused-const-variable=]
     261 | static const struct acpi_device_id cbas_ec_acpi_ids[] = {
         |                                    ^~~~~~~~~~~~~~~~

The 'cbas_ec_acpi_ids' array is only used when CONFIG_ACPI is enabled.
Wrapping its definition and 'MODULE_DEVICE_TABLE' in '#ifdef CONFIG_ACPI'
prevents a compiler warning when ACPI is disabled.

Fixes: eb1aac4c ("HID: google: add support tablet mode switch for Whiskers")
Reported-by: default avatarkernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202501201141.jctFH5eB-lkp@intel.com/


Signed-off-by: default avatarYu-Chun Lin <eleanor15x@gmail.com>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.com>
parent 44afc10d
Loading
Loading
Loading
Loading
+2 −0
Original line number Diff line number Diff line
@@ -268,11 +268,13 @@ static void cbas_ec_remove(struct platform_device *pdev)
	mutex_unlock(&cbas_ec_reglock);
}

#ifdef CONFIG_ACPI
static const struct acpi_device_id cbas_ec_acpi_ids[] = {
	{ "GOOG000B", 0 },
	{ }
};
MODULE_DEVICE_TABLE(acpi, cbas_ec_acpi_ids);
#endif

#ifdef CONFIG_OF
static const struct of_device_id cbas_ec_of_match[] = {