Commit 4be011d7 authored Jul 30, 2024 by Ido Schimmel Committed by Jakub Kicinski Jul 31, 2024

mlxsw: core_thermal: Remove unnecessary check



mlxsw_thermal_modules_init() allocates an array of modules and then
calls mlxsw_thermal_module_init() to initialize each entry in the array.
It is therefore impossible for mlxsw_thermal_module_init() to encounter
an entry that is already initialized and has its 'parent' pointer set.

Remove the unnecessary check.

Signed-off-by: Ido Schimmel <idosch@nvidia.com>
Reviewed-by: Vadim Pasternak <vadimp@nvidia.com>
Signed-off-by: Petr Machata <petrm@nvidia.com>
Reviewed-by: Wojciech Drewek <wojciech.drewek@intel.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

parent a1bb54b1

drivers/net/ethernet/mellanox/mlxsw/core_thermal.c

+0 −3

Original line number	Diff line number	Diff line
		@@ -453,9 +453,6 @@ mlxsw_thermal_module_init(struct device dev, struct mlxsw_core core,
		struct mlxsw_thermal_module *module_tz;

		module_tz = &area->tz_module_arr[module];
		/* Skip if parent is already set (case of port split). */
		if (module_tz->parent)
		return;
		module_tz->module = module;
		module_tz->slot_index = area->slot_index;
		module_tz->parent = thermal;