Commit 4c0d9477 authored by Johan Hovold's avatar Johan Hovold
Browse files

USB: serial: kobil_sct: restore initial terminal settings 



Commit 6a6c8b36 ("usb, kobil: Sort out some bogus tty handling")
intended to fix and clean up the device-specific initial terminal
settings but instead confused the termios input and local control flags
and re-enabled ICRNL and IXON.

Drop the bogus masking of l-flags from the default i-flags (which has no
effect) and restore the original device-specific i-flags.

Fixes: 6a6c8b36 ("usb, kobil: Sort out some bogus tty handling")
Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
parent 6d243588

drivers/usb/serial/kobil_sct.c

+1 −2
Original line number Diff line number Diff line
@@ -155,8 +155,7 @@ static void kobil_init_termios(struct tty_struct *tty) 
{

	/* Default to echo off and other sane device settings */

	tty->termios.c_lflag = 0;

	tty->termios.c_iflag &= ~(ISIG | ICANON | ECHO | IEXTEN | XCASE);

	tty->termios.c_iflag |= IGNBRK | IGNPAR | IXOFF;

	tty->termios.c_iflag = IGNBRK | IGNPAR | IXOFF;

	/* do NOT translate CR to CR-NL (0x0A -> 0x0A 0x0D) */

	tty->termios.c_oflag &= ~ONLCR;

}