Commit 4c0fb1af authored by Wolfram Sang's avatar Wolfram Sang Committed by Greg Kroah-Hartman
Browse files

misc: tifm: use 'time_left' variable with wait_for_completion_timeout() 



There is a confusing pattern in the kernel to use a variable named 'timeout' to
store the result of wait_for_completion_timeout() causing patterns like:

	timeout = wait_for_completion_timeout(...)
	if (!timeout) return -ETIMEDOUT;

with all kinds of permutations. Use 'time_left' as a variable to make the code
self explaining.

Signed-off-by: default avatarWolfram Sang <wsa+renesas@sang-engineering.com>
Link: https://lore.kernel.org/r/20240604212240.4529-4-wsa+renesas@sang-engineering.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 531a185d

drivers/misc/tifm_7xx1.c

+3 −3
Original line number Diff line number Diff line
@@ -229,7 +229,7 @@ static int __maybe_unused tifm_7xx1_resume(struct device *dev_d) 
	struct pci_dev *dev = to_pci_dev(dev_d);

	struct tifm_adapter *fm = pci_get_drvdata(dev);

	int rc;

	unsigned long timeout;

	unsigned long time_left;

	unsigned int good_sockets = 0, bad_sockets = 0;

	unsigned long flags;

	/* Maximum number of entries is 4 */
@@ -265,8 +265,8 @@ static int __maybe_unused tifm_7xx1_resume(struct device *dev_d) 
	if (good_sockets) {

		fm->finish_me = &finish_resume;

		spin_unlock_irqrestore(&fm->lock, flags);

		timeout = wait_for_completion_timeout(&finish_resume, HZ);

		dev_dbg(&dev->dev, "wait returned %lu\n", timeout);

		time_left = wait_for_completion_timeout(&finish_resume, HZ);

		dev_dbg(&dev->dev, "wait returned %lu\n", time_left);

		writel(TIFM_IRQ_FIFOMASK(good_sockets)

		       | TIFM_IRQ_CARDMASK(good_sockets),

		       fm->addr + FM_CLEAR_INTERRUPT_ENABLE);