Commit 4c122450 authored by Anumula Murali Mohan Reddy's avatar Anumula Murali Mohan Reddy Committed by Jakub Kicinski
Browse files

cxgb4: Avoid removal of uninserted tid 



During ARP failure, tid is not inserted but _c4iw_free_ep()
attempts to remove tid which results in error.
This patch fixes the issue by avoiding removal of uninserted tid.

Fixes: 59437d78 ("cxgb4/chtls: fix ULD connection failures due to wrong TID base")
Signed-off-by: default avatarAnumula Murali Mohan Reddy <anumula@chelsio.com>
Signed-off-by: default avatarPotnuri Bharat Teja <bharat@chelsio.com>
Link: https://patch.msgid.link/20250103092327.1011925-1-anumula@chelsio.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 3085d4b8

drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c

+4 −1
Original line number Diff line number Diff line
@@ -1799,7 +1799,10 @@ void cxgb4_remove_tid(struct tid_info *t, unsigned int chan, unsigned int tid, 
	struct adapter *adap = container_of(t, struct adapter, tids);

	struct sk_buff *skb;



	WARN_ON(tid_out_of_range(&adap->tids, tid));

	if (tid_out_of_range(&adap->tids, tid)) {

		dev_err(adap->pdev_dev, "tid %d out of range\n", tid);

		return;

	}



	if (t->tid_tab[tid - adap->tids.tid_base]) {

		t->tid_tab[tid - adap->tids.tid_base] = NULL;