Commit 4c148191 authored Jul 09, 2022 by Yang Jihong Committed by Arnaldo Carvalho de Melo Jul 26, 2022

perf kwork: Add softirq report support



Implements softirq kwork report function.

Test cases:

  # perf kwork -k softirq rep

    Kwork Name                     | Cpu  | Total Runtime | Count     | Max runtime   | Max runtime start   | Max runtime end     |
   --------------------------------------------------------------------------------------------------------------------------------
    (s)TIMER:1                     | 0003 |    181.387 ms |      2476 |      1.240 ms |      44004.787960 s |      44004.789201 s |
    (s)RCU:9                       | 0003 |     91.573 ms |      2193 |      0.650 ms |      44004.790258 s |      44004.790908 s |
    (s)RCU:9                       | 0001 |     78.960 ms |      1619 |      1.195 ms |      44001.496553 s |      44001.497749 s |
    (s)SCHED:7                     | 0003 |     55.962 ms |      1255 |      0.954 ms |      44004.812008 s |      44004.812962 s |
    ... <SNIP> ...
    (s)RCU:9                       | 0004 |      0.830 ms |        26 |      0.058 ms |      43997.666418 s |      43997.666476 s |
    (s)TIMER:1                     | 0001 |      0.471 ms |         4 |      0.158 ms |      44007.834694 s |      44007.834852 s |
    (s)RCU:9                       | 0006 |      0.220 ms |         7 |      0.048 ms |      44004.833764 s |      44004.833812 s |
    (s)NET_RX:3                    | 0002 |      0.164 ms |         5 |      0.049 ms |      44005.012418 s |      44005.012466 s |
    (s)TIMER:1                     | 0005 |      0.164 ms |         1 |      0.164 ms |      44007.820474 s |      44007.820638 s |
    (s)TIMER:1                     | 0006 |      0.087 ms |         1 |      0.087 ms |      44000.830807 s |      44000.830894 s |
    (s)SCHED:7                     | 0006 |      0.080 ms |         2 |      0.044 ms |      43997.826145 s |      43997.826189 s |
   --------------------------------------------------------------------------------------------------------------------------------

  #
  # perf kwork -k softirq rep -S

    Kwork Name                     | Cpu  | Total Runtime | Count     | Max runtime   | Max runtime start   | Max runtime end     |
   --------------------------------------------------------------------------------------------------------------------------------
    (s)TIMER:1                     | 0003 |    181.387 ms |      2476 |      1.240 ms |      44004.787960 s |      44004.789201 s |
    (s)RCU:9                       | 0003 |     91.573 ms |      2193 |      0.650 ms |      44004.790258 s |      44004.790908 s |
    (s)RCU:9                       | 0001 |     78.960 ms |      1619 |      1.195 ms |      44001.496553 s |      44001.497749 s |
    (s)SCHED:7                     | 0000 |     63.631 ms |       680 |      2.690 ms |      44006.721976 s |      44006.724666 s |
    ... <SNIP> ...
    (s)SCHED:7                     | 0003 |     55.962 ms |      1255 |      0.954 ms |      44004.812008 s |      44004.812962 s |
    (s)RCU:9                       | 0006 |      0.220 ms |         7 |      0.048 ms |      44004.833764 s |      44004.833812 s |
    (s)NET_RX:3                    | 0002 |      0.164 ms |         5 |      0.049 ms |      44005.012418 s |      44005.012466 s |
    (s)TIMER:1                     | 0005 |      0.164 ms |         1 |      0.164 ms |      44007.820474 s |      44007.820638 s |
    (s)TIMER:1                     | 0006 |      0.087 ms |         1 |      0.087 ms |      44000.830807 s |      44000.830894 s |
    (s)SCHED:7                     | 0006 |      0.080 ms |         2 |      0.044 ms |      43997.826145 s |      43997.826189 s |
   --------------------------------------------------------------------------------------------------------------------------------
    Total count            :     12748
    Total runtime   (msec) :   661.433 (0.065% load average)
    Total time span (msec) : 10176.441
   --------------------------------------------------------------------------------------------------------------------------------

  #
  # perf kwork -k softirq rep -s count,max

    Kwork Name                     | Cpu  | Total Runtime | Count     | Max runtime   | Max runtime start   | Max runtime end     |
   --------------------------------------------------------------------------------------------------------------------------------
    (s)TIMER:1                     | 0003 |    181.387 ms |      2476 |      1.240 ms |      44004.787960 s |      44004.789201 s |
    (s)RCU:9                       | 0003 |     91.573 ms |      2193 |      0.650 ms |      44004.790258 s |      44004.790908 s |
    (s)SCHED:7                     | 0002 |     50.039 ms |      1731 |      0.074 ms |      44005.009447 s |      44005.009521 s |
    (s)RCU:9                       | 0001 |     78.960 ms |      1619 |      1.195 ms |      44001.496553 s |      44001.497749 s |
    (s)SCHED:7                     | 0003 |     55.962 ms |      1255 |      0.954 ms |      44004.812008 s |      44004.812962 s |
    ... <SNIP> ...
    (s)RCU:9                       | 0002 |     35.241 ms |       932 |      0.407 ms |      44005.009541 s |      44005.009949 s |
    (s)RCU:9                       | 0000 |     45.710 ms |       702 |      1.144 ms |      44004.787023 s |      44004.788167 s |
    (s)SCHED:7                     | 0006 |      0.080 ms |         2 |      0.044 ms |      43997.826145 s |      43997.826189 s |
    (s)TIMER:1                     | 0005 |      0.164 ms |         1 |      0.164 ms |      44007.820474 s |      44007.820638 s |
    (s)TIMER:1                     | 0006 |      0.087 ms |         1 |      0.087 ms |      44000.830807 s |      44000.830894 s |
   --------------------------------------------------------------------------------------------------------------------------------

Committer testing:

  # perf kwork -k softirq report -C 2 -s count,max

  Kwork Name                     | Cpu  | Total Runtime | Count     | Max runtime   | Max runtime start   | Max runtime end     |
 --------------------------------------------------------------------------------------------------------------------------------
  (s)SCHED:7                     | 0002 |      0.980 ms |       159 |      0.024 ms |      26035.571037 s |      26035.571061 s |
  (s)RCU:9                       | 0002 |      0.124 ms |        88 |      0.021 ms |      26035.177050 s |      26035.177071 s |
  (s)TIMER:1                     | 0002 |      0.122 ms |        56 |      0.007 ms |      26035.468045 s |      26035.468052 s |
 --------------------------------------------------------------------------------------------------------------------------------

  #

Signed-off-by: Yang Jihong <yangjihong1@huawei.com>
Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Paul Clarke <pc@us.ibm.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: https://lore.kernel.org/r/20220709015033.38326-9-yangjihong1@huawei.com


Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

parent 94348520

tools/perf/builtin-kwork.c

+96 −2

Original line number	Diff line number	Diff line
		@@ -550,17 +550,111 @@ static struct kwork_class kwork_irq = {
		.work_name = irq_work_name,
		};

		static struct kwork_class kwork_softirq;
		static int process_softirq_entry_event(struct perf_tool *tool,
		struct evsel *evsel,
		struct perf_sample *sample,
		struct machine *machine)
		{
		struct perf_kwork *kwork = container_of(tool, struct perf_kwork, tool);

		if (kwork->tp_handler->entry_event)
		return kwork->tp_handler->entry_event(kwork, &kwork_softirq,
		evsel, sample, machine);

		return 0;
		}

		static int process_softirq_exit_event(struct perf_tool *tool,
		struct evsel *evsel,
		struct perf_sample *sample,
		struct machine *machine)
		{
		struct perf_kwork *kwork = container_of(tool, struct perf_kwork, tool);

		if (kwork->tp_handler->exit_event)
		return kwork->tp_handler->exit_event(kwork, &kwork_softirq,
		evsel, sample, machine);

		return 0;
		}

		const struct evsel_str_handler softirq_tp_handlers[] = {
		{ "irq:softirq_raise", NULL, },
		{ "irq:softirq_entry", NULL, },
		{ "irq:softirq_exit", NULL, },
		{ "irq:softirq_entry", process_softirq_entry_event, },
		{ "irq:softirq_exit", process_softirq_exit_event, },
		};

		static int softirq_class_init(struct kwork_class *class,
		struct perf_session *session)
		{
		if (perf_session__set_tracepoints_handlers(session,
		softirq_tp_handlers)) {
		pr_err("Failed to set softirq tracepoints handlers\n");
		return -1;
		}

		class->work_root = RB_ROOT_CACHED;
		return 0;
		}

		static char evsel__softirq_name(struct evsel evsel, u64 num)
		{
		char *name = NULL;
		bool found = false;
		struct tep_print_flag_sym *sym = NULL;
		struct tep_print_arg *args = evsel->tp_format->print_fmt.args;

		if ((args == NULL) \|\| (args->next == NULL))
		return NULL;

		/* skip softirq field: "REC->vec" */
		for (sym = args->next->symbol.symbols; sym != NULL; sym = sym->next) {
		if ((eval_flag(sym->value) == (unsigned long long)num) &&
		(strlen(sym->str) != 0)) {
		found = true;
		break;
		}
		}

		if (!found)
		return NULL;

		name = strdup(sym->str);
		if (name == NULL) {
		pr_err("Failed to copy symbol name\n");
		return NULL;
		}
		return name;
		}

		static void softirq_work_init(struct kwork_class *class,
		struct kwork_work *work,
		struct evsel *evsel,
		struct perf_sample *sample,
		struct machine *machine __maybe_unused)
		{
		u64 num = evsel__intval(evsel, sample, "vec");

		work->id = num;
		work->class = class;
		work->cpu = sample->cpu;
		work->name = evsel__softirq_name(evsel, num);
		}

		static void softirq_work_name(struct kwork_work work, char buf, int len)
		{
		snprintf(buf, len, "(s)%s:%" PRIu64 "", work->name, work->id);
		}

		static struct kwork_class kwork_softirq = {
		.name = "softirq",
		.type = KWORK_CLASS_SOFTIRQ,
		.nr_tracepoints = 3,
		.tp_handlers = softirq_tp_handlers,
		.class_init = softirq_class_init,
		.work_init = softirq_work_init,
		.work_name = softirq_work_name,
		};

		const struct evsel_str_handler workqueue_tp_handlers[] = {