Commit 4c239d5f authored by Youngjun Park's avatar Youngjun Park Committed by Andrew Morton
Browse files

mm: swap: change swap_alloc_slow() to void 

swap_alloc_slow() does not need to return a bool, as all callers handle
allocation results via the entry parameter.  Update the function signature
and remove return statements accordingly.

Link: https://lkml.kernel.org/r/20251031065011.40863-5-youngjun.park@lge.com


Signed-off-by: default avatarYoungjun Park <youngjun.park@lge.com>
Reviewed-by: default avatarKairui Song <kasong@tencent.com>
Reviewed-by: default avatarBaoquan He <bhe@redhat.com>
Acked-by: default avatarChris Li <chrisl@kernel.org>
Cc: Barry Song <baohua@kernel.org>
Cc: Kemeng Shi <shikemeng@huaweicloud.com>
Cc: Nhat Pham <nphamcs@gmail.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent f1bae15c

mm/swapfile.c

+3 −4
Original line number Diff line number Diff line
@@ -1339,7 +1339,7 @@ static bool swap_alloc_fast(swp_entry_t *entry, 
}



/* Rotate the device and switch to a new cluster */

static bool swap_alloc_slow(swp_entry_t *entry,

static void swap_alloc_slow(swp_entry_t *entry,

			    int order)

{

	unsigned long offset;
@@ -1356,10 +1356,10 @@ static bool swap_alloc_slow(swp_entry_t *entry, 
			put_swap_device(si);

			if (offset) {

				*entry = swp_entry(si->type, offset);

				return true;

				return;

			}

			if (order)

				return false;

				return;

		}



		spin_lock(&swap_avail_lock);
@@ -1378,7 +1378,6 @@ static bool swap_alloc_slow(swp_entry_t *entry, 
			goto start_over;

	}

	spin_unlock(&swap_avail_lock);

	return false;

}



/*