Commit 4c267ae2 authored by Takashi Iwai's avatar Takashi Iwai
Browse files

ALSA: sb: Force to disable DMAs once when DMA mode is changed 

When the DMA mode is changed on the (still real!) SB AWE32 after
playing a stream and closing, the previous DMA setup was still
silently kept, and it can confuse the hardware, resulting in the
unexpected noises.  As a workaround, enforce the disablement of DMA
setups when the DMA setup is changed by the kcontrol.

https://bugzilla.kernel.org/show_bug.cgi?id=218185
Link: https://patch.msgid.link/20250610064322.26787-2-tiwai@suse.de


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent ed29e073

sound/isa/sb/sb16_main.c

+4 −0
Original line number Diff line number Diff line
@@ -714,6 +714,10 @@ static int snd_sb16_dma_control_put(struct snd_kcontrol *kcontrol, struct snd_ct 
	change = nval != oval;

	snd_sb16_set_dma_mode(chip, nval);

	spin_unlock_irqrestore(&chip->reg_lock, flags);

	if (change) {

		snd_dma_disable(chip->dma8);

		snd_dma_disable(chip->dma16);

	}

	return change;

}