Commit 4c4ca3c4 authored by Oliver Neukum's avatar Oliver Neukum Committed by Jakub Kicinski
Browse files

usb: net: sierra: check for no status endpoint 



The driver checks for having three endpoints and
having bulk in and out endpoints, but not that
the third endpoint is interrupt input.
Rectify the omission.

Reported-by: default avatar <syzbot+3f89ec3d1d0842e95d50@syzkaller.appspotmail.com>
Closes: https://lore.kernel.org/linux-usb/686d5a9f.050a0220.1ffab7.0017.GAE@google.com/


Tested-by: default avatar <syzbot+3f89ec3d1d0842e95d50@syzkaller.appspotmail.com>
Fixes: eb4fd8cd ("net/usb: add sierra_net.c driver")
Signed-off-by: default avatarOliver Neukum <oneukum@suse.com>
Link: https://patch.msgid.link/20250714111326.258378-1-oneukum@suse.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 0e941896

drivers/net/usb/sierra_net.c

+4 −0
Original line number Diff line number Diff line
@@ -689,6 +689,10 @@ static int sierra_net_bind(struct usbnet *dev, struct usb_interface *intf) 
			status);

		return -ENODEV;

	}

	if (!dev->status) {

		dev_err(&dev->udev->dev, "No status endpoint found");

		return -ENODEV;

	}

	/* Initialize sierra private data */

	priv = kzalloc(sizeof *priv, GFP_KERNEL);

	if (!priv)