Commit 4c53e392 authored by Pavel Begunkov's avatar Pavel Begunkov Committed by Jens Axboe
Browse files

io_uring: use no mmap safe region helpers on resizing 



io_create_region_mmap_safe() is only needed when the created region is
exposed to userspace code via mmap. io_register_resize_rings() creates
them locally on stack, so the no mmap_safe version of the helper is
enough.

Signed-off-by: default avatarPavel Begunkov <asml.silence@gmail.com>
Reviewed-by: default avatarGabriel Krisman Bertazi <krisman@suse.de>
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 284306f6

io_uring/register.c

+2 −2
Original line number Diff line number Diff line
@@ -432,7 +432,7 @@ static int io_register_resize_rings(struct io_ring_ctx *ctx, void __user *arg) 
		rd.user_addr = p.cq_off.user_addr;

		rd.flags |= IORING_MEM_REGION_TYPE_USER;

	}

	ret = io_create_region_mmap_safe(ctx, &n.ring_region, &rd, IORING_OFF_CQ_RING);

	ret = io_create_region(ctx, &n.ring_region, &rd, IORING_OFF_CQ_RING);

	if (ret) {

		io_register_free_rings(ctx, &p, &n);

		return ret;
@@ -472,7 +472,7 @@ static int io_register_resize_rings(struct io_ring_ctx *ctx, void __user *arg) 
		rd.user_addr = p.sq_off.user_addr;

		rd.flags |= IORING_MEM_REGION_TYPE_USER;

	}

	ret = io_create_region_mmap_safe(ctx, &n.sq_region, &rd, IORING_OFF_SQES);

	ret = io_create_region(ctx, &n.sq_region, &rd, IORING_OFF_SQES);

	if (ret) {

		io_register_free_rings(ctx, &p, &n);

		return ret;