Commit 4c6a567c authored by Johannes Thumshirn's avatar Johannes Thumshirn Committed by Viacheslav Dubeyko
Browse files

hfsplus: don't set REQ_SYNC for hfsplus_submit_bio() 



hfsplus_submit_bio() called by hfsplus_sync_fs() uses bdev_virt_rw() which
in turn uses submit_bio_wait() to submit the BIO.

But submit_bio_wait() already sets the REQ_SYNC flag on the BIO so there
is no need for setting the flag in hfsplus_sync_fs() when calling
hfsplus_submit_bio().

Signed-off-by: default avatarJohannes Thumshirn <johannes.thumshirn@wdc.com>
Reviewed-by: default avatarYangtao Li <frank.li@vivo.com>
Reviewed-by: default avatarViacheslav Dubeyko <slava@dubeyko.com>
Signed-off-by: default avatarViacheslav Dubeyko <slava@dubeyko.com>
Link: https://lore.kernel.org/r/20250710063553.4805-1-johannes.thumshirn@wdc.com
Link: https://lore.kernel.org/r/20250710063553.4805-1-johannes.thumshirn@wdc.com


Signed-off-by: default avatarViacheslav Dubeyko <slava@dubeyko.com>
parent fcb96956

fs/hfsplus/super.c

+2 −4
Original line number Diff line number Diff line
@@ -222,8 +222,7 @@ static int hfsplus_sync_fs(struct super_block *sb, int wait) 


	error2 = hfsplus_submit_bio(sb,

				   sbi->part_start + HFSPLUS_VOLHEAD_SECTOR,

				   sbi->s_vhdr_buf, NULL, REQ_OP_WRITE |

				   REQ_SYNC);

				   sbi->s_vhdr_buf, NULL, REQ_OP_WRITE);

	if (!error)

		error = error2;

	if (!write_backup)
@@ -231,8 +230,7 @@ static int hfsplus_sync_fs(struct super_block *sb, int wait) 


	error2 = hfsplus_submit_bio(sb,

				  sbi->part_start + sbi->sect_count - 2,

				  sbi->s_backup_vhdr_buf, NULL, REQ_OP_WRITE |

				  REQ_SYNC);

				  sbi->s_backup_vhdr_buf, NULL, REQ_OP_WRITE);

	if (!error)

		error2 = error;

out: