Commit 4c800227 authored by Muhammad Usama Anjum's avatar Muhammad Usama Anjum Committed by Jakub Kicinski
Browse files

fou: fix initialization of grc 



The grc must be initialize first. There can be a condition where if
fou is NULL, goto out will be executed and grc would be used
uninitialized.

Fixes: 7e419693 ("fou: Fix null-ptr-deref in GRO.")
Signed-off-by: default avatarMuhammad Usama Anjum <usama.anjum@collabora.com>
Reviewed-by: default avatarKuniyuki Iwashima <kuniyu@amazon.com>
Link: https://patch.msgid.link/20240906102839.202798-1-usama.anjum@collabora.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent b3c9e65e

net/ipv4/fou_core.c

+2 −2
Original line number Diff line number Diff line
@@ -336,11 +336,11 @@ static struct sk_buff *gue_gro_receive(struct sock *sk, 
	struct gro_remcsum grc;

	u8 proto;



	skb_gro_remcsum_init(&grc);



	if (!fou)

		goto out;



	skb_gro_remcsum_init(&grc);



	off = skb_gro_offset(skb);

	len = off + sizeof(*guehdr);