Commit 4ca01292 authored by Lorenzo Bianconi's avatar Lorenzo Bianconi Committed by Jakub Kicinski
Browse files

net: airoha: Do not return err in ndo_stop() callback 



Always complete the airoha_dev_stop() routine regardless of the
airoha_set_vip_for_gdm_port() return value, since errors from
ndo_stop() are ignored by the networking stack and the interface is
always considered down after the call.

Fixes: 23020f04 ("net: airoha: Introduce ethernet support for EN7581 SoC")
Signed-off-by: default avatarLorenzo Bianconi <lorenzo@kernel.org>
Link: https://patch.msgid.link/20260428-airoha-ndo-stop-not-err-v1-1-674506d29a91@kernel.org


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent b3168120

drivers/net/ethernet/airoha/airoha_eth.c

+2 −5
Original line number Diff line number Diff line
@@ -1747,13 +1747,10 @@ static int airoha_dev_stop(struct net_device *dev) 
{

	struct airoha_gdm_port *port = netdev_priv(dev);

	struct airoha_qdma *qdma = port->qdma;

	int i, err;

	int i;



	netif_tx_disable(dev);

	err = airoha_set_vip_for_gdm_port(port, false);

	if (err)

		return err;



	airoha_set_vip_for_gdm_port(port, false);

	for (i = 0; i < dev->num_tx_queues; i++)

		netdev_tx_reset_subqueue(dev, i);