Unverified Commit 4cf006b7 authored by NeilBrown's avatar NeilBrown Committed by Christian Brauner
Browse files

nfsd: drop fh_update() from S_IFDIR branch of nfsd_create_locked() 



nfsd_create_locked() doesn't need to explicitly call fh_update().
On success (which is the only time that fh_update() matters at all),
nfsd_create_setattr() will be called and it will call fh_update().

This extra call is not harmful, but is not necessary.

Signed-off-by: default avatarNeilBrown <neilb@suse.de>
Link: https://lore.kernel.org/r/20250226062135.2043651-3-neilb@suse.de


Signed-off-by: default avatarChristian Brauner <brauner@kernel.org>
parent 3ff6c870

fs/nfsd/vfs.c

+0 −3
Original line number Diff line number Diff line
@@ -1505,11 +1505,8 @@ nfsd_create_locked(struct svc_rqst *rqstp, struct svc_fh *fhp, 
			}

			dput(resfhp->fh_dentry);

			resfhp->fh_dentry = dget(d);

			err = fh_update(resfhp);

			dput(dchild);

			dchild = d;

			if (err)

				goto out;

		}

		break;

	case S_IFCHR: