Unverified Commit 4d2ea165 authored by Peter Ujfalusi's avatar Peter Ujfalusi Committed by Mark Brown
Browse files

ASoC: SOF: pcm: Move period/buffer configuration print after platform open 



The platform specific pcm_open call via snd_sof_pcm_platform_open() can
modify the initial buffer configuration via constraints.

Move the prints as last step in the sof_pcm_open() function to reflect the
final setup.

Signed-off-by: default avatarPeter Ujfalusi <peter.ujfalusi@linux.intel.com>
Reviewed-by: default avatarLiam Girdwood <liam.r.girdwood@intel.com>
Reviewed-by: default avatarBard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: default avatarRanjani Sridharan <ranjani.sridharan@linux.intel.com>
Link: https://patch.msgid.link/20250206092828.7569-3-peter.ujfalusi@linux.intel.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 169ec0a5

sound/soc/sof/pcm.c

+13 −11
Original line number Diff line number Diff line
@@ -536,15 +536,6 @@ static int sof_pcm_open(struct snd_soc_component *component, 
	 */

	runtime->hw.buffer_bytes_max = le32_to_cpu(caps->buffer_size_max);



	dev_dbg(component->dev, "period min %zd max %zd bytes\n",

		runtime->hw.period_bytes_min,

		runtime->hw.period_bytes_max);

	dev_dbg(component->dev, "period count %d max %d\n",

		runtime->hw.periods_min,

		runtime->hw.periods_max);

	dev_dbg(component->dev, "buffer max %zd bytes\n",

		runtime->hw.buffer_bytes_max);



	/* set wait time - TODO: come from topology */

	substream->wait_time = 500;
@@ -554,12 +545,23 @@ static int sof_pcm_open(struct snd_soc_component *component, 
	spcm->prepared[substream->stream] = false;



	ret = snd_sof_pcm_platform_open(sdev, substream);

	if (ret < 0)

	if (ret < 0) {

		dev_err(component->dev, "error: pcm open failed %d\n", ret);



		return ret;

	}



	dev_dbg(component->dev, "period bytes min %zd, max %zd\n",

		runtime->hw.period_bytes_min,

		runtime->hw.period_bytes_max);

	dev_dbg(component->dev, "period count min %d, max %d\n",

		runtime->hw.periods_min,

		runtime->hw.periods_max);

	dev_dbg(component->dev, "buffer bytes max %zd\n",

		runtime->hw.buffer_bytes_max);



	return 0;

}



static int sof_pcm_close(struct snd_soc_component *component,

			 struct snd_pcm_substream *substream)

{