Commit 4d3a13af authored by Mario Limonciello (AMD)'s avatar Mario Limonciello (AMD) Committed by Jiri Kosina
Browse files

HID: amd_sfh: Stop sensor before starting 



Titas reports that the accelerometer sensor on their laptop only
works after a warm boot or unloading/reloading the amd-sfh kernel
module.

Presumably the sensor is in a bad state on cold boot and failing to
start, so explicitly stop it before starting.

Cc: stable@vger.kernel.org
Fixes: 93ce5e02 ("HID: amd_sfh: Implement SFH1.1 functionality")
Reported-by: default avatarTitas <novatitas366@gmail.com>
Closes: https://bugzilla.kernel.org/show_bug.cgi?id=220670


Tested-by: default avatarTitas <novatitas366@gmail.com>
Signed-off-by: default avatarMario Limonciello (AMD) <superm1@kernel.org>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.com>
parent 743c81cd

drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_init.c

+2 −0
Original line number Diff line number Diff line
@@ -194,6 +194,8 @@ static int amd_sfh1_1_hid_client_init(struct amd_mp2_dev *privdata) 
		if (rc)

			goto cleanup;



		mp2_ops->stop(privdata, cl_data->sensor_idx[i]);

		amd_sfh_wait_for_response(privdata, cl_data->sensor_idx[i], DISABLE_SENSOR);

		writel(0, privdata->mmio + amd_get_p2c_val(privdata, 0));

		mp2_ops->start(privdata, info);

		status = amd_sfh_wait_for_response