Commit 4da4a48b authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Herbert Xu
Browse files

hwrng: omap - Convert to platform remove callback returning void 



The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.

To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent e5906ee3

drivers/char/hw_random/omap-rng.c

+2 −4
Original line number Diff line number Diff line
@@ -509,7 +509,7 @@ static int omap_rng_probe(struct platform_device *pdev) 
	return ret;

}



static int omap_rng_remove(struct platform_device *pdev)

static void omap_rng_remove(struct platform_device *pdev)

{

	struct omap_rng_dev *priv = platform_get_drvdata(pdev);
@@ -521,8 +521,6 @@ static int omap_rng_remove(struct platform_device *pdev) 


	clk_disable_unprepare(priv->clk);

	clk_disable_unprepare(priv->clk_reg);



	return 0;

}



static int __maybe_unused omap_rng_suspend(struct device *dev)
@@ -560,7 +558,7 @@ static struct platform_driver omap_rng_driver = { 
		.of_match_table = of_match_ptr(omap_rng_of_match),

	},

	.probe		= omap_rng_probe,

	.remove		= omap_rng_remove,

	.remove_new	= omap_rng_remove,

};



module_platform_driver(omap_rng_driver);