Commit 4dc48c88 authored by Zijun Hu's avatar Zijun Hu Committed by Vinod Koul
Browse files

phy: core: Fix that API devm_phy_destroy() fails to destroy the phy 



For devm_phy_destroy(), its comment says it needs to invoke phy_destroy()
to destroy the phy, but it will not actually invoke the function since
devres_destroy() does not call devm_phy_consume(), and the missing
phy_destroy() call will cause that the phy fails to be destroyed.

Fortunately, the faulty API has not been used by current kernel tree.
Fix by using devres_release() instead of devres_destroy() within the API.

Fixes: ff764963 ("drivers: phy: add generic PHY framework")
Reviewed-by: default avatarJohan Hovold <johan+linaro@kernel.org>
Signed-off-by: default avatarZijun Hu <quic_zijuhu@quicinc.com>
Link: https://lore.kernel.org/r/20241213-phy_core_fix-v6-3-40ae28f5015a@quicinc.com


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent c0b82ab9

drivers/phy/phy-core.c

+1 −1
Original line number Diff line number Diff line
@@ -1121,7 +1121,7 @@ void devm_phy_destroy(struct device *dev, struct phy *phy) 
{

	int r;



	r = devres_destroy(dev, devm_phy_consume, devm_phy_match, phy);

	r = devres_release(dev, devm_phy_consume, devm_phy_match, phy);

	dev_WARN_ONCE(dev, r, "couldn't find PHY resource\n");

}

EXPORT_SYMBOL_GPL(devm_phy_destroy);