Commit 4dcd0e83 authored by Dan Carpenter's avatar Dan Carpenter Committed by Jakub Kicinski
Browse files

net: ti: icssg-prueth: Fix signedness bug in prueth_init_rx_chns() 



The rx_chn->irq[] array is unsigned int but it should be signed for the
error handling to work.  Also if k3_udma_glue_rx_get_irq() returns zero
then we should return -ENXIO instead of success.

Fixes: 128d5874 ("net: ti: icssg-prueth: Add ICSSG ethernet driver")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: default avatarRoger Quadros <rogerq@kernel.org>
Reviewed-by: default avatarMD Danish Anwar <danishanwar@ti.com>
Link: https://lore.kernel.org/r/05282415-e7f4-42f3-99f8-32fde8f30936@moroto.mountain


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 46bf0c9a

drivers/net/ethernet/ti/icssg/icssg_prueth.c

+5 −3
Original line number Diff line number Diff line
@@ -421,12 +421,14 @@ static int prueth_init_rx_chns(struct prueth_emac *emac, 
		if (!i)

			fdqring_id = k3_udma_glue_rx_flow_get_fdq_id(rx_chn->rx_chn,

								     i);

		rx_chn->irq[i] = k3_udma_glue_rx_get_irq(rx_chn->rx_chn, i);

		if (rx_chn->irq[i] <= 0) {

			ret = rx_chn->irq[i];

		ret = k3_udma_glue_rx_get_irq(rx_chn->rx_chn, i);

		if (ret <= 0) {

			if (!ret)

				ret = -ENXIO;

			netdev_err(ndev, "Failed to get rx dma irq");

			goto fail;

		}

		rx_chn->irq[i] = ret;

	}



	return 0;