Unverified Commit 4dd7f8ae authored by Richard Fitzgerald's avatar Richard Fitzgerald Committed by Mark Brown
Browse files

ASoC: cs35l56: Use SOC_ENUM_EXT_ACC() for CAL_SET_STATUS control 



Use the new SOC_ENUM_EXT_ACC() macro instead of SOC_ENUM_EXT() to
define the CAL_SET_STATUS control, so that it is marked as read-only
and volatile.

This avoids userland code expecting to be able to write to it and
then getting an unexpected EPERM error, or assuming that its value
can never change.

Signed-off-by: default avatarRichard Fitzgerald <rf@opensource.cirrus.com>
Link: https://patch.msgid.link/20251120134437.1179191-4-rf@opensource.cirrus.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent d7a82707

sound/soc/codecs/cs35l56.c

+6 −4
Original line number Diff line number Diff line
@@ -95,8 +95,9 @@ static const struct snd_kcontrol_new cs35l56_controls[] = { 
	SOC_SINGLE_EXT("Posture Number", CS35L56_MAIN_POSTURE_NUMBER,

		       0, 255, 0,

		       cs35l56_dspwait_get_volsw, cs35l56_dspwait_put_volsw),

	SOC_ENUM_EXT("CAL_SET_STATUS", cs35l56_cal_set_status_enum,

		     cs35l56_cal_set_status_ctl_get, NULL),

	SOC_ENUM_EXT_ACC("CAL_SET_STATUS", cs35l56_cal_set_status_enum,

			 cs35l56_cal_set_status_ctl_get, NULL,

			 SNDRV_CTL_ELEM_ACCESS_READ | SNDRV_CTL_ELEM_ACCESS_VOLATILE),

};



static const struct snd_kcontrol_new cs35l63_controls[] = {
@@ -116,8 +117,9 @@ static const struct snd_kcontrol_new cs35l63_controls[] = { 
	SOC_SINGLE_EXT("Posture Number", CS35L63_MAIN_POSTURE_NUMBER,

		       0, 255, 0,

		       cs35l56_dspwait_get_volsw, cs35l56_dspwait_put_volsw),

	SOC_ENUM_EXT("CAL_SET_STATUS", cs35l56_cal_set_status_enum,

		     cs35l56_cal_set_status_ctl_get, NULL),

	SOC_ENUM_EXT_ACC("CAL_SET_STATUS", cs35l56_cal_set_status_enum,

			 cs35l56_cal_set_status_ctl_get, NULL,

			 SNDRV_CTL_ELEM_ACCESS_READ | SNDRV_CTL_ELEM_ACCESS_VOLATILE),

};



static SOC_VALUE_ENUM_SINGLE_DECL(cs35l56_asp1tx1_enum,