Commit 4e4ac533 authored by Jijie Shao's avatar Jijie Shao Committed by Jakub Kicinski
Browse files

net: hibmcge: fix wrong mtu log issue 



A dbg log is generated when the driver modifies the MTU,
which is expected to trace the change of the MTU.

However, the log is recorded after WRITE_ONCE().
At this time, netdev->mtu has been changed to the new value.
As a result, netdev->mtu is the same as new_mtu.

This patch modifies the log location and records logs before WRITE_ONCE().

Fixes: ff4edac6 ("net: hibmcge: Implement some .ndo functions")
Signed-off-by: default avatarJijie Shao <shaojijie@huawei.com>
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20250410021327.590362-5-shaojijie@huawei.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 4ad3df75

drivers/net/ethernet/hisilicon/hibmcge/hbg_main.c

+3 −3
Original line number Diff line number Diff line
@@ -203,12 +203,12 @@ static int hbg_net_change_mtu(struct net_device *netdev, int new_mtu) 
	if (netif_running(netdev))

		return -EBUSY;



	hbg_hw_set_mtu(priv, new_mtu);

	WRITE_ONCE(netdev->mtu, new_mtu);



	dev_dbg(&priv->pdev->dev,

		"change mtu from %u to %u\n", netdev->mtu, new_mtu);



	hbg_hw_set_mtu(priv, new_mtu);

	WRITE_ONCE(netdev->mtu, new_mtu);



	return 0;

}