Commit 4e75697f authored by Elena Reshetova's avatar Elena Reshetova Committed by Dave Hansen
Browse files

x86/sgx: Implement ENCLS[EUPDATESVN] 



All running enclaves and cryptographic assets (such as internal SGX
encryption keys) are assumed to be compromised whenever an SGX-related
microcode update occurs. To mitigate this assumed compromise the new
supervisor SGX instruction ENCLS[EUPDATESVN] can generate fresh
cryptographic assets.

Before executing EUPDATESVN, all SGX memory must be marked as unused. This
requirement ensures that no potentially compromised enclave survives the
update and allows the system to safely regenerate cryptographic assets.

Add the method to perform ENCLS[EUPDATESVN]. However, until the follow up
patch that wires calling sgx_update_svn() from sgx_inc_usage_count(), this
code is not reachable.

Signed-off-by: default avatarElena Reshetova <elena.reshetova@intel.com>
Signed-off-by: default avatarDave Hansen <dave.hansen@linux.intel.com>
Reviewed-by: default avatarKai Huang <kai.huang@intel.com>
Reviewed-by: default avatarJarkko Sakkinen <jarkko@kernel.org>
Tested-by: default avatarNataliia Bondarevska <bondarn@google.com>
parent 7b502832

arch/x86/include/asm/sgx.h

+16 −15
Original line number Diff line number Diff line
@@ -43,6 +43,7 @@ enum sgx_encls_function { 
	EAUG		= 0x0D,

	EMODPR		= 0x0E,

	EMODT		= 0x0F,

	EUPDATESVN	= 0x18,

};



/**

arch/x86/kernel/cpu/sgx/encls.h

+5 −0
Original line number Diff line number Diff line
@@ -233,4 +233,9 @@ static inline int __eaug(struct sgx_pageinfo *pginfo, void *addr) 
	return __encls_2(EAUG, pginfo, addr);

}



/* Attempt to update CPUSVN at runtime. */

static inline int __eupdatesvn(void)

{

	return __encls_ret_1(EUPDATESVN, "");

}

#endif /* _X86_ENCLS_H */

arch/x86/kernel/cpu/sgx/main.c

+75 −0
Original line number Diff line number Diff line
@@ -16,6 +16,7 @@ 
#include <linux/vmalloc.h>

#include <asm/msr.h>

#include <asm/sgx.h>

#include <asm/archrandom.h>

#include "driver.h"

#include "encl.h"

#include "encls.h"
@@ -917,6 +918,80 @@ int sgx_set_attribute(unsigned long *allowed_attributes, 
}

EXPORT_SYMBOL_GPL(sgx_set_attribute);



/* Counter to count the active SGX users */

static int sgx_usage_count;



/**

 * sgx_update_svn() - Attempt to call ENCLS[EUPDATESVN].

 *

 * This instruction attempts to update CPUSVN to the

 * currently loaded microcode update SVN and generate new

 * cryptographic assets.

 *

 * Return:

 * * %0:       - Success or not supported

 * * %-EAGAIN: - Can be safely retried, failure is due to lack of

 * *             entropy in RNG

 * * %-EIO:    - Unexpected error, retries are not advisable

 */

static int __maybe_unused sgx_update_svn(void)

{

	int ret;



	/*

	 * If EUPDATESVN is not available, it is ok to

	 * silently skip it to comply with legacy behavior.

	 */

	if (!cpu_feature_enabled(X86_FEATURE_SGX_EUPDATESVN))

		return 0;



	/*

	 * EPC is guaranteed to be empty when there are no users.

	 * Ensure we are on our first user before proceeding further.

	 */

	WARN(sgx_usage_count, "Elevated usage count when calling EUPDATESVN\n");



	for (int i = 0; i < RDRAND_RETRY_LOOPS; i++) {

		ret = __eupdatesvn();



		/* Stop on success or unexpected errors: */

		if (ret != SGX_INSUFFICIENT_ENTROPY)

			break;

	}



	switch (ret) {

	case 0:

		/*

		 * SVN successfully updated.

		 * Let users know when the update was successful.

		 */

		pr_info("SVN updated successfully\n");

		return 0;

	case SGX_NO_UPDATE:

		/*

		 * SVN update failed since the current SVN is

		 * not newer than CPUSVN. This is the most

		 * common case and indicates no harm.

		 */

		return 0;

	case SGX_INSUFFICIENT_ENTROPY:

		/*

		 * SVN update failed due to lack of entropy in DRNG.

		 * Indicate to userspace that it should retry.

		 */

		return -EAGAIN;

	default:

		break;

	}



	/*

	 * EUPDATESVN was called when EPC is empty, all other error

	 * codes are unexpected.

	 */

	ENCLS_WARN(ret, "EUPDATESVN");

	return -EIO;

}



int sgx_inc_usage_count(void)

{

	return 0;