Commit 4e9fda29 authored by Pavel Begunkov's avatar Pavel Begunkov Committed by Jens Axboe
Browse files

io_uring/kbuf: drop extra vars in io_register_pbuf_ring 



bl and free_bl variables in io_register_pbuf_ring() always point to the
same list since we started to reallocate the pre-existent list. Drop
free_bl.

Signed-off-by: default avatarPavel Begunkov <asml.silence@gmail.com>
Link: https://lore.kernel.org/r/d45c3342d74c9030f99376c777a4b3d59089074d.1747150490.git.asml.silence@gmail.com


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 17248490

io_uring/kbuf.c

+3 −3
Original line number Diff line number Diff line
@@ -591,7 +591,7 @@ int io_provide_buffers(struct io_kiocb *req, unsigned int issue_flags) 
int io_register_pbuf_ring(struct io_ring_ctx *ctx, void __user *arg)

{

	struct io_uring_buf_reg reg;

	struct io_buffer_list *bl, *free_bl = NULL;

	struct io_buffer_list *bl;

	struct io_uring_region_desc rd;

	struct io_uring_buf_ring *br;

	unsigned long mmap_offset;
@@ -620,7 +620,7 @@ int io_register_pbuf_ring(struct io_ring_ctx *ctx, void __user *arg) 
		io_destroy_bl(ctx, bl);

	}



	free_bl = bl = kzalloc(sizeof(*bl), GFP_KERNEL_ACCOUNT);

	bl = kzalloc(sizeof(*bl), GFP_KERNEL_ACCOUNT);

	if (!bl)

		return -ENOMEM;
@@ -665,7 +665,7 @@ int io_register_pbuf_ring(struct io_ring_ctx *ctx, void __user *arg) 
	return 0;

fail:

	io_free_region(ctx, &bl->region);

	kfree(free_bl);

	kfree(bl);

	return ret;

}