Commit 4ead534f authored by David Laight's avatar David Laight Committed by Andrew Morton
Browse files

minmax: allow comparisons of 'int' against 'unsigned char/short' 

Since 'unsigned char/short' get promoted to 'signed int' it is safe to
compare them against an 'int' value.

Link: https://lkml.kernel.org/r/8732ef5f809c47c28a7be47c938b28d4@AcuMS.aculab.com


Signed-off-by: default avatarDavid Laight <david.laight@aculab.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Christoph Hellwig <hch@infradead.org>
Cc: Jason A. Donenfeld <Jason@zx2c4.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Matthew Wilcox (Oracle) <willy@infradead.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent f4b84b2f

include/linux/minmax.h

+3 −2
Original line number Diff line number Diff line
@@ -27,7 +27,8 @@ 
		is_signed_type(typeof(x)), 0)



#define __types_ok(x, y) 			\

	(__is_signed(x) == __is_signed(y))

	(__is_signed(x) == __is_signed(y) ||	\

		__is_signed((x) + 0) == __is_signed((y) + 0))



#define __cmp_op_min <

#define __cmp_op_max >