Commit 4ec752ce authored by Trond Myklebust's avatar Trond Myklebust
Browse files

NFS/localio: nfs_uuid_put() fix the wake up after unlinking the file 



Use store_release_wake_up() instead of wake_up_var_locked(), because the
waiter cannot retake the nfs_uuid->lock.

Acked-by: default avatarMike Snitzer <snitzer@kernel.org>
Tested-by: default avatarMike Snitzer <snitzer@kernel.org>
Suggested-by: default avatarNeilBrown <neil@brown.name>
Link: https://lore.kernel.org/all/175262948827.2234665.1891349021754495573@noble.neil.brown.name/


Fixes: 21fb4403 ("nfs_localio: protect race between nfs_uuid_put() and nfs_close_local_fh()")
Signed-off-by: default avatarTrond Myklebust <trond.myklebust@hammerspace.com>
parent fdd015de

fs/nfs_common/nfslocalio.c

+1 −2
Original line number Diff line number Diff line
@@ -198,8 +198,7 @@ static bool nfs_uuid_put(nfs_uuid_t *nfs_uuid) 
		/* Now we can allow racing nfs_close_local_fh() to

		 * skip the locking.

		 */

		RCU_INIT_POINTER(nfl->nfs_uuid, NULL);

		wake_up_var_locked(&nfl->nfs_uuid, &nfs_uuid->lock);

		store_release_wake_up(&nfl->nfs_uuid, RCU_INITIALIZER(NULL));

	}



	/* Remove client from nn->local_clients */