Commit 4f0d22ec authored by Bartosz Golaszewski's avatar Bartosz Golaszewski Committed by Linus Walleij
Browse files

pinctrl: lpass-lpi: implement .get_direction() for the GPIO driver 



GPIO controller driver should typically implement the .get_direction()
callback as GPIOLIB internals may try to use it to determine the state
of a pin. Add it for the LPASS LPI driver.

Reported-by: default avatarAbel Vesa <abelvesa@kernel.org>
Cc: stable@vger.kernel.org
Fixes: 6e261d10 ("pinctrl: qcom: Add sm8250 lpass lpi pinctrl driver")
Signed-off-by: default avatarBartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Reviewed-by: default avatarKonrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Tested-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> # X1E CRD
Tested-by: default avatarAbel Vesa <abel.vesa@oss.qualcomm.com>
Signed-off-by: default avatarLinus Walleij <linusw@kernel.org>
parent 304c3ebc

drivers/pinctrl/qcom/pinctrl-lpass-lpi.c

+17 −0
Original line number Diff line number Diff line
@@ -312,6 +312,22 @@ static const struct pinconf_ops lpi_gpio_pinconf_ops = { 
	.pin_config_group_set		= lpi_config_set,

};



static int lpi_gpio_get_direction(struct gpio_chip *chip, unsigned int pin)

{

	unsigned long config = pinconf_to_config_packed(PIN_CONFIG_LEVEL, 0);

	struct lpi_pinctrl *state = gpiochip_get_data(chip);

	unsigned long arg;

	int ret;



	ret = lpi_config_get(state->ctrl, pin, &config);

	if (ret)

		return ret;



	arg = pinconf_to_config_argument(config);



	return arg ? GPIO_LINE_DIRECTION_OUT : GPIO_LINE_DIRECTION_IN;

}



static int lpi_gpio_direction_input(struct gpio_chip *chip, unsigned int pin)

{

	struct lpi_pinctrl *state = gpiochip_get_data(chip);
@@ -409,6 +425,7 @@ static void lpi_gpio_dbg_show(struct seq_file *s, struct gpio_chip *chip) 
#endif



static const struct gpio_chip lpi_gpio_template = {

	.get_direction		= lpi_gpio_get_direction,

	.direction_input	= lpi_gpio_direction_input,

	.direction_output	= lpi_gpio_direction_output,

	.get			= lpi_gpio_get,