Commit 4f152338 authored by Nagarjuna Kristam's avatar Nagarjuna Kristam Committed by Manivannan Sadhasivam
Browse files

PCI: tegra194: Fix duplicate PLL disable in pex_ep_event_pex_rst_assert() 



During PERST# assertion tegra_pcie_bpmp_set_pll_state() is currently
called twice.

pex_ep_event_pex_rst_assert() should do the opposite of
pex_ep_event_pex_rst_deassert(), so it is obvious that the duplicate
tegra_pcie_bpmp_set_pll_state() is a mistake, and that the duplicate
tegra_pcie_bpmp_set_pll_state() call should instead be a call to
tegra_pcie_bpmp_set_ctrl_state().

With this, the uninitialization sequence also matches that of
tegra_pcie_unconfig_controller().

Fixes: a54e1907 ("PCI: tegra194: Add Tegra234 PCIe support")
Signed-off-by: default avatarNagarjuna Kristam <nkristam@nvidia.com>
[cassel: improve commit log]
Signed-off-by: default avatarNiklas Cassel <cassel@kernel.org>
Link: https://patch.msgid.link/20250911093021.1454385-2-cassel@kernel.org


[mani: added Fixes tag]
Signed-off-by: default avatarManivannan Sadhasivam <mani@kernel.org>
parent e1a8805e

drivers/pci/controller/dwc/pcie-tegra194.c

+2 −2
Original line number Diff line number Diff line
@@ -1722,9 +1722,9 @@ static void pex_ep_event_pex_rst_assert(struct tegra_pcie_dw *pcie) 
				ret);

	}



	ret = tegra_pcie_bpmp_set_pll_state(pcie, false);

	ret = tegra_pcie_bpmp_set_ctrl_state(pcie, false);

	if (ret)

		dev_err(pcie->dev, "Failed to turn off UPHY: %d\n", ret);

		dev_err(pcie->dev, "Failed to disable controller: %d\n", ret);



	pcie->ep_state = EP_STATE_DISABLED;

	dev_dbg(pcie->dev, "Uninitialization of endpoint is completed\n");