Unverified Commit 4f3b63e8 authored by Sentaro Onizuka's avatar Sentaro Onizuka Committed by Christian Brauner
Browse files

fs: Fix return type of do_mount() from long to int 



Fix the return type of do_mount() function from long to int to match its ac
tual behavior. The function only returns int values, and all callers, inclu
ding those in fs/namespace.c and arch/alpha/kernel/osf_sys.c, already treat
 the return value as int. This change improves type consistency across the
filesystem code and aligns the function signature with its existing impleme
ntation and usage.

Signed-off-by: default avatarSentaro Onizuka <sentaro@amazon.com>
Link: https://lore.kernel.org/r/20250113151400.55512-1-sentaro@amazon.com


Signed-off-by: default avatarChristian Brauner <brauner@kernel.org>
parent 344af277

fs/namespace.c

+1 −1
Original line number Diff line number Diff line
@@ -3835,7 +3835,7 @@ int path_mount(const char *dev_name, struct path *path, 
			    data_page);

}



long do_mount(const char *dev_name, const char __user *dir_name,

int do_mount(const char *dev_name, const char __user *dir_name,

		const char *type_page, unsigned long flags, void *data_page)

{

	struct path path;

include/linux/mount.h

+1 −1
Original line number Diff line number Diff line
@@ -114,7 +114,7 @@ extern struct vfsmount *kern_mount(struct file_system_type *); 
extern void kern_unmount(struct vfsmount *mnt);

extern int may_umount_tree(struct vfsmount *);

extern int may_umount(struct vfsmount *);

extern long do_mount(const char *, const char __user *,

int do_mount(const char *, const char __user *,

		     const char *, unsigned long, void *);

extern struct vfsmount *collect_mounts(const struct path *);

extern void drop_collected_mounts(struct vfsmount *);