Commit 4f6473ad authored by Florian Fainelli's avatar Florian Fainelli Committed by Jakub Kicinski
Browse files

net: dsa: Leverage core stats allocator 



With commit 34d21de9 ("net: Move {l,t,d}stats allocation to core
and convert veth & vrf"), stats allocation could be done on net core
instead of in this driver.

With this new approach, the driver doesn't have to bother with error
handling (allocation failure checking, making sure free happens in the
right spot, etc). This is core responsibility now.

Remove the allocation in the DSA user network device code and leverage
the network core allocation instead.

Signed-off-by: default avatarFlorian Fainelli <florian.fainelli@broadcom.com>
Reviewed-by: default avatarBreno Leitao <leitao@debian.org>
Link: https://lore.kernel.org/r/20240306200416.2973179-1-florian.fainelli@broadcom.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent c12264d3

net/dsa/user.c

+1 −7
Original line number Diff line number Diff line
@@ -2625,11 +2625,7 @@ int dsa_user_create(struct dsa_port *port) 
	user_dev->vlan_features = conduit->vlan_features;



	p = netdev_priv(user_dev);

	user_dev->tstats = netdev_alloc_pcpu_stats(struct pcpu_sw_netstats);

	if (!user_dev->tstats) {

		free_netdev(user_dev);

		return -ENOMEM;

	}

	user_dev->pcpu_stat_type = NETDEV_PCPU_STAT_TSTATS;



	ret = gro_cells_init(&p->gcells, user_dev);

	if (ret)
@@ -2695,7 +2691,6 @@ int dsa_user_create(struct dsa_port *port) 
out_gcells:

	gro_cells_destroy(&p->gcells);

out_free:

	free_percpu(user_dev->tstats);

	free_netdev(user_dev);

	port->user = NULL;

	return ret;
@@ -2716,7 +2711,6 @@ void dsa_user_destroy(struct net_device *user_dev) 


	dsa_port_phylink_destroy(dp);

	gro_cells_destroy(&p->gcells);

	free_percpu(user_dev->tstats);

	free_netdev(user_dev);

}