Commit 4f70a045 authored by Michal Koutný's avatar Michal Koutný Committed by Peter Zijlstra
Browse files

sched/rt: Move group schedulability check to sched_rt_global_validate() 



The sched_rt_global_constraints() function is a remnant that used to set
up global RT throttling but that is no more since commit 5f6bd380
("sched/rt: Remove default bandwidth control") and the function ended up
only doing schedulability check.
Move the check into the validation function where it fits better.
(The order of validations sched_dl_global_validate() and
sched_rt_global_validate() shouldn't matter.)

Signed-off-by: default avatarMichal Koutný <mkoutny@suse.com>
Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
Link: https://patch.msgid.link/20260323-sched-rert_groups-v3-2-1e7d5ed6b249@suse.com
parent 8b016dce

kernel/sched/rt.c

+8 −9
Original line number Diff line number Diff line
@@ -2832,15 +2832,7 @@ long sched_group_rt_period(struct task_group *tg) 
#ifdef CONFIG_SYSCTL

static int sched_rt_global_constraints(void)

{

	int ret = 0;

	if (!rt_group_sched_enabled())

		return ret;



	mutex_lock(&rt_constraints_mutex);

	ret = __rt_schedulable(NULL, 0, 0);

	mutex_unlock(&rt_constraints_mutex);



	return ret;

	return 0;

}

#endif /* CONFIG_SYSCTL */
@@ -2872,6 +2864,13 @@ static int sched_rt_global_validate(void) 
			NSEC_PER_USEC > max_rt_runtime)))

		return -EINVAL;



#ifdef CONFIG_RT_GROUP_SCHED

	if (!rt_group_sched_enabled())

		return 0;



	scoped_guard(mutex, &rt_constraints_mutex)

		return __rt_schedulable(NULL, 0, 0);

#endif

	return 0;

}