Commit 4f7f4170 authored by Vishal Chourasia's avatar Vishal Chourasia Committed by Tejun Heo
Browse files

sched_ext: Fix function pointer type mismatches in BPF selftests 



Fix incompatible function pointer type warnings in sched_ext BPF selftests by
explicitly casting the function pointers when initializing struct_ops.
This addresses multiple -Wincompatible-function-pointer-types warnings from the
clang compiler where function signatures didn't match exactly.

The void * cast ensures the compiler accepts the function pointer
assignment despite minor type differences in the parameters.

Signed-off-by: default avatarVishal Chourasia <vishalc@linux.ibm.com>
Signed-off-by: default avatarTejun Heo <tj@kernel.org>
parent 9b3c11a8

tools/testing/selftests/sched_ext/create_dsq.bpf.c

+3 −3
Original line number Diff line number Diff line
@@ -51,8 +51,8 @@ s32 BPF_STRUCT_OPS_SLEEPABLE(create_dsq_init) 


SEC(".struct_ops.link")

struct sched_ext_ops create_dsq_ops = {

	.init_task		= create_dsq_init_task,

	.exit_task		= create_dsq_exit_task,

	.init			= create_dsq_init,

	.init_task		= (void *) create_dsq_init_task,

	.exit_task		= (void *) create_dsq_exit_task,

	.init			= (void *) create_dsq_init,

	.name			= "create_dsq",

};

tools/testing/selftests/sched_ext/ddsp_bogus_dsq_fail.bpf.c

+2 −2
Original line number Diff line number Diff line
@@ -35,8 +35,8 @@ void BPF_STRUCT_OPS(ddsp_bogus_dsq_fail_exit, struct scx_exit_info *ei) 


SEC(".struct_ops.link")

struct sched_ext_ops ddsp_bogus_dsq_fail_ops = {

	.select_cpu		= ddsp_bogus_dsq_fail_select_cpu,

	.exit			= ddsp_bogus_dsq_fail_exit,

	.select_cpu		= (void *) ddsp_bogus_dsq_fail_select_cpu,

	.exit			= (void *) ddsp_bogus_dsq_fail_exit,

	.name			= "ddsp_bogus_dsq_fail",

	.timeout_ms		= 1000U,

};

tools/testing/selftests/sched_ext/ddsp_vtimelocal_fail.bpf.c

+2 −2
Original line number Diff line number Diff line
@@ -32,8 +32,8 @@ void BPF_STRUCT_OPS(ddsp_vtimelocal_fail_exit, struct scx_exit_info *ei) 


SEC(".struct_ops.link")

struct sched_ext_ops ddsp_vtimelocal_fail_ops = {

	.select_cpu		= ddsp_vtimelocal_fail_select_cpu,

	.exit			= ddsp_vtimelocal_fail_exit,

	.select_cpu		= (void *) ddsp_vtimelocal_fail_select_cpu,

	.exit			= (void *) ddsp_vtimelocal_fail_exit,

	.name			= "ddsp_vtimelocal_fail",

	.timeout_ms		= 1000U,

};

tools/testing/selftests/sched_ext/dsp_local_on.bpf.c

+4 −4
Original line number Diff line number Diff line
@@ -56,10 +56,10 @@ void BPF_STRUCT_OPS(dsp_local_on_exit, struct scx_exit_info *ei) 


SEC(".struct_ops.link")

struct sched_ext_ops dsp_local_on_ops = {

	.select_cpu		= dsp_local_on_select_cpu,

	.enqueue		= dsp_local_on_enqueue,

	.dispatch		= dsp_local_on_dispatch,

	.exit			= dsp_local_on_exit,

	.select_cpu		= (void *) dsp_local_on_select_cpu,

	.enqueue		= (void *) dsp_local_on_enqueue,

	.dispatch		= (void *) dsp_local_on_dispatch,

	.exit			= (void *) dsp_local_on_exit,

	.name			= "dsp_local_on",

	.timeout_ms		= 1000U,

};

tools/testing/selftests/sched_ext/enq_select_cpu_fails.bpf.c

+2 −2
Original line number Diff line number Diff line
@@ -36,8 +36,8 @@ void BPF_STRUCT_OPS(enq_select_cpu_fails_enqueue, struct task_struct *p, 


SEC(".struct_ops.link")

struct sched_ext_ops enq_select_cpu_fails_ops = {

	.select_cpu		= enq_select_cpu_fails_select_cpu,

	.enqueue		= enq_select_cpu_fails_enqueue,

	.select_cpu		= (void *) enq_select_cpu_fails_select_cpu,

	.enqueue		= (void *) enq_select_cpu_fails_enqueue,

	.name			= "enq_select_cpu_fails",

	.timeout_ms		= 1000U,

};