Unverified Commit 4f854a8b authored by Matthew Brost's avatar Matthew Brost Committed by Rodrigo Vivi
Browse files

drm/xe: Use dma_fence_chain_free in chain fence unused as a sync 



A chain fence is uninitialized if not installed in a drm sync obj. Thus
if xe_sync_entry_cleanup is called and sync->chain_fence is non-NULL the
proper cleanup is dma_fence_chain_free rather than a dma-fence put.

Reported-by: default avatarPaulo Zanoni <paulo.r.zanoni@intel.com>
Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/2411
Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/2261


Fixes: dd08ebf6 ("drm/xe: Introduce a new DRM driver for Intel GPUs")
Signed-off-by: default avatarMatthew Brost <matthew.brost@intel.com>
Reviewed-by: default avatarMatthew Auld <matthew.auld@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240727012216.2118276-1-matthew.brost@intel.com


(cherry picked from commit 7f7a2da3)
Signed-off-by: default avatarRodrigo Vivi <rodrigo.vivi@intel.com>
parent ae02c7b7

drivers/gpu/drm/xe/xe_sync.c

+1 −1
Original line number Diff line number Diff line
@@ -263,7 +263,7 @@ void xe_sync_entry_cleanup(struct xe_sync_entry *sync) 
	if (sync->fence)

		dma_fence_put(sync->fence);

	if (sync->chain_fence)

		dma_fence_put(&sync->chain_fence->base);

		dma_fence_chain_free(sync->chain_fence);

	if (sync->ufence)

		user_fence_put(sync->ufence);

}