Commit 4fa4b010 authored by Linus Torvalds's avatar Linus Torvalds Committed by Steven Rostedt (Google)
Browse files

eventfs: Initialize the tracefs inode properly 

The tracefs-specific fields in the inode were not initialized before the
inode was exposed to others through the dentry with 'd_instantiate()'.

Move the field initializations up to before the d_instantiate.

Link: https://lore.kernel.org/linux-trace-kernel/20240131185512.478449628@goodmis.org



Cc: stable@vger.kernel.org
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: Christian Brauner <brauner@kernel.org>
Cc: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Ajay Kaher <ajay.kaher@broadcom.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Fixes: 5790b1fb ("eventfs: Remove eventfs_file and just use eventfs_inode")
Reported-by: default avatarkernel test robot <oliver.sang@intel.com>
Closes: https://lore.kernel.org/oe-lkp/202401291043.e62e89dc-oliver.sang@intel.com


Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: default avatarSteven Rostedt (Google) <rostedt@goodmis.org>
parent d81786f5

fs/tracefs/event_inode.c

+2 −4
Original line number Diff line number Diff line
@@ -370,6 +370,8 @@ static struct dentry *create_dir(struct eventfs_inode *ei, struct dentry *parent 


	ti = get_tracefs(inode);

	ti->flags |= TRACEFS_EVENT_INODE;

	/* Only directories have ti->private set to an ei, not files */

	ti->private = ei;



	inc_nlink(inode);

	d_instantiate(dentry, inode);
@@ -515,7 +517,6 @@ create_file_dentry(struct eventfs_inode *ei, int idx, 
static void eventfs_post_create_dir(struct eventfs_inode *ei)

{

	struct eventfs_inode *ei_child;

	struct tracefs_inode *ti;



	lockdep_assert_held(&eventfs_mutex);
@@ -525,9 +526,6 @@ static void eventfs_post_create_dir(struct eventfs_inode *ei) 
				 srcu_read_lock_held(&eventfs_srcu)) {

		ei_child->d_parent = ei->dentry;

	}



	ti = get_tracefs(ei->dentry->d_inode);

	ti->private = ei;

}



/**