Commit 503bbde3 authored by Oliver Neukum's avatar Oliver Neukum Committed by Greg Kroah-Hartman
Browse files

usb: core: usb_submit_urb: downgrade type check 



Checking for the endpoint type is no reason for a WARN, as that can
cause a reboot. A driver not checking the endpoint type must not cause a
reboot, as there is just no point in this.  We cannot prevent a device
from doing something incorrect as a reaction to a transfer. Hence
warning for a mere assumption being wrong is not sensible.

Signed-off-by: default avatarOliver Neukum <oneukum@suse.com>
Acked-by: default avatarAlan Stern <stern@rowland.harvard.edu>
Link: https://lore.kernel.org/r/20250612122149.2559724-1-oneukum@suse.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 7bf742b0

drivers/usb/core/urb.c

+1 −1
Original line number Diff line number Diff line
@@ -500,7 +500,7 @@ int usb_submit_urb(struct urb *urb, gfp_t mem_flags) 


	/* Check that the pipe's type matches the endpoint's type */

	if (usb_pipe_type_check(urb->dev, urb->pipe))

		dev_WARN(&dev->dev, "BOGUS urb xfer, pipe %x != type %x\n",

		dev_warn_once(&dev->dev, "BOGUS urb xfer, pipe %x != type %x\n",

			usb_pipetype(urb->pipe), pipetypes[xfertype]);



	/* Check against a simple/standard policy */