Commit 5068d840 authored by Yiwei Lin's avatar Yiwei Lin Committed by Peter Zijlstra
Browse files

sched/fair: Update min_vruntime for reweight_entity() correctly 



Since reweight_entity() may have chance to change the weight of
cfs_rq->curr entity, we should also update_min_vruntime() if
this is the case

Fixes: eab03c23 ("sched/eevdf: Fix vruntime adjustment on reweight")
Signed-off-by: default avatarYiwei Lin <s921975628@gmail.com>
Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: default avatarAbel Wu <wuyun.abel@bytedance.com>
Link: https://lore.kernel.org/r/20231117080106.12890-1-s921975628@gmail.com
parent 0257e5a3

kernel/sched/fair.c

+10 −10
Original line number Diff line number Diff line
@@ -3815,7 +3815,9 @@ static void reweight_entity(struct cfs_rq *cfs_rq, struct sched_entity *se, 
	enqueue_load_avg(cfs_rq, se);

	if (se->on_rq) {

		update_load_add(&cfs_rq->load, se->load.weight);

		if (!curr) {

		if (!curr)

			__enqueue_entity(cfs_rq, se);



		/*

		 * The entity's vruntime has been adjusted, so let's check

		 * whether the rq-wide min_vruntime needs updated too. Since
@@ -3823,11 +3825,9 @@ static void reweight_entity(struct cfs_rq *cfs_rq, struct sched_entity *se, 
		 * than up-to-date one, we do the update at the end of the

		 * reweight process.

		 */

			__enqueue_entity(cfs_rq, se);

		update_min_vruntime(cfs_rq);

	}

}

}



void reweight_task(struct task_struct *p, int prio)

{