Commit 50690733 authored by Cosmin Ratiu's avatar Cosmin Ratiu Committed by Jakub Kicinski
Browse files

net/mlx5e: psp: Expose only a fully initialized priv->psp 



Currently, during PSP init, priv->psp is initialized to an incompletely
built psp struct. Additionally, on fs init failure priv->psp is reset to
NULL.

Change this so that only a fully initialized priv->psp is set, which
makes the code easier to reason about in failure scenarios.

Fixes: af2196f4 ("net/mlx5e: Implement PSP operations .assoc_add and .assoc_del")
Signed-off-by: default avatarCosmin Ratiu <cratiu@nvidia.com>
Reviewed-by: default avatarDragos Tatulea <dtatulea@nvidia.com>
Signed-off-by: default avatarTariq Toukan <tariqt@nvidia.com>
Link: https://patch.msgid.link/20260504181100.269334-3-tariqt@nvidia.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent ae9582cd

drivers/net/ethernet/mellanox/mlx5/core/en_accel/psp.c

+3 −7
Original line number Diff line number Diff line
@@ -1139,22 +1139,18 @@ int mlx5e_psp_init(struct mlx5e_priv *priv) 
	if (!psp)

		return -ENOMEM;



	priv->psp = psp;

	fs = mlx5e_accel_psp_fs_init(priv);

	if (IS_ERR(fs)) {

		err = PTR_ERR(fs);

		goto out_err;

		kfree(psp);

		return err;

	}



	psp->fs = fs;

	priv->psp = psp;



	mlx5_core_dbg(priv->mdev, "PSP attached to netdevice\n");

	return 0;



out_err:

	priv->psp = NULL;

	kfree(psp);

	return err;

}



void mlx5e_psp_cleanup(struct mlx5e_priv *priv)