Commit 5072b8e9 authored by Michael Riesch's avatar Michael Riesch Committed by Vinod Koul
Browse files

dt-bindings: phy: rockchip-inno-csi-dphy: add rk3588 variant 



The Rockchip RK3588 variant of the CSI-2 DPHY features two reset lines.
Add the variant and allow for the additional reset.

While at it, fix the description of the first reset in order to avoid
confusion.

Signed-off-by: default avatarMichael Riesch <michael.riesch@collabora.com>
Reviewed-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://lore.kernel.org/r/20250616-rk3588-csi-dphy-v4-3-a4f340a7f0cf@collabora.com


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent c254815b

Documentation/devicetree/bindings/phy/rockchip-inno-csi-dphy.yaml

+49 −1
Original line number Diff line number Diff line
@@ -21,6 +21,7 @@ properties: 
      - rockchip,rk3326-csi-dphy

      - rockchip,rk3368-csi-dphy

      - rockchip,rk3568-csi-dphy

      - rockchip,rk3588-csi-dphy



  reg:

    maxItems: 1
@@ -40,11 +41,15 @@ properties: 


  resets:

    items:

      - description: exclusive PHY reset line

      - description: APB reset line

      - description: PHY reset line

    minItems: 1



  reset-names:

    items:

      - const: apb

      - const: phy

    minItems: 1



  rockchip,grf:

    $ref: /schemas/types.yaml#/definitions/phandle
@@ -74,6 +79,30 @@ allOf: 
    then:

      required:

        - power-domains

  - if:

      properties:

        compatible:

          contains:

            enum:

              - rockchip,px30-csi-dphy

              - rockchip,rk1808-csi-dphy

              - rockchip,rk3326-csi-dphy

              - rockchip,rk3368-csi-dphy

              - rockchip,rk3568-csi-dphy

    then:

      properties:

        resets:

          maxItems: 1



        reset-names:

          maxItems: 1

    else:

      properties:

        resets:

          minItems: 2



        reset-names:

          minItems: 2



additionalProperties: false
@@ -91,3 +120,22 @@ examples: 
        reset-names = "apb";

        rockchip,grf = <&grf>;

    };

  - |

    #include <dt-bindings/clock/rockchip,rk3588-cru.h>

    #include <dt-bindings/reset/rockchip,rk3588-cru.h>



    soc {

        #address-cells = <2>;

        #size-cells = <2>;



        phy@fedc0000 {

            compatible = "rockchip,rk3588-csi-dphy";

            reg = <0x0 0xfedc0000 0x0 0x8000>;

            clocks = <&cru PCLK_CSIPHY0>;

            clock-names = "pclk";

            #phy-cells = <0>;

            resets = <&cru SRST_P_CSIPHY0>, <&cru SRST_CSIPHY0>;

            reset-names = "apb", "phy";

            rockchip,grf = <&csidphy0_grf>;

        };

    };