Commit 508bd94c authored by Thomas Gleixner's avatar Thomas Gleixner
Browse files

genirq/manage: Rework enable_percpu_irq() 



Use the new guards to get and lock the interrupt descriptor and tidy up the
code.

No functional change.

Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Acked-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lore.kernel.org/all/20250429065422.315844964@linutronix.de
parent 90140d08

kernel/irq/manage.c

+16 −26
Original line number Diff line number Diff line
@@ -2286,12 +2286,8 @@ int request_nmi(unsigned int irq, irq_handler_t handler, 


void enable_percpu_irq(unsigned int irq, unsigned int type)

{

	unsigned int cpu = smp_processor_id();

	unsigned long flags;

	struct irq_desc *desc = irq_get_desc_lock(irq, &flags, IRQ_GET_DESC_CHECK_PERCPU);



	if (!desc)

		return;

	scoped_irqdesc_get_and_lock(irq, IRQ_GET_DESC_CHECK_PERCPU) {

		struct irq_desc *desc = scoped_irqdesc;



		/*

		 * If the trigger type is not specified by the caller, then
@@ -2302,19 +2298,13 @@ void enable_percpu_irq(unsigned int irq, unsigned int type) 
			type = irqd_get_trigger_type(&desc->irq_data);



		if (type != IRQ_TYPE_NONE) {

		int ret;



		ret = __irq_set_trigger(desc, type);



		if (ret) {

			if (__irq_set_trigger(desc, type)) {

				WARN(1, "failed to set type for IRQ%d\n", irq);

			goto out;

				return;

			}

		}



	irq_percpu_enable(desc, cpu);

out:

	irq_put_desc_unlock(desc, flags);

		irq_percpu_enable(desc, smp_processor_id());

	}

}

EXPORT_SYMBOL_GPL(enable_percpu_irq);