Commit 50ad88d5 authored by Hangbin Liu's avatar Hangbin Liu Committed by Jakub Kicinski
Browse files

selftests: net: remove redundant rp_filter configuration 



The following tests use setup_ns to create a network namespace, which
will disables rp_filter immediately after namespace creation. Therefore,
it is no longer necessary to disable rp_filter again within these individual
tests.

Signed-off-by: default avatarHangbin Liu <liuhangbin@gmail.com>
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20250508081910.84216-3-liuhangbin@gmail.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent ce17831f

tools/testing/selftests/net/fib_rule_tests.sh

+0 −3
Original line number Diff line number Diff line
@@ -516,10 +516,7 @@ fib_rule4_test() 
	fib_rule4_test_match_n_redirect "$match" "$match" "$getnomatch" \

		"oif redirect to table" "oif no redirect to table"



	# Enable forwarding and disable rp_filter as all the addresses are in

	# the same subnet and egress device == ingress device.

	ip netns exec $testns sysctl -qw net.ipv4.ip_forward=1

	ip netns exec $testns sysctl -qw net.ipv4.conf.$DEV.rp_filter=0

	match="from $SRC_IP iif $DEV"

	getnomatch="from $SRC_IP iif lo"

	fib_rule4_test_match_n_redirect "$match" "$match" "$getnomatch" \

tools/testing/selftests/net/fib_tests.sh

+0 −3
Original line number Diff line number Diff line
@@ -2560,9 +2560,6 @@ ipv4_mpath_list_test() 
	run_cmd "ip -n $ns2 route add 203.0.113.0/24

		nexthop via 172.16.201.2 nexthop via 172.16.202.2"

	run_cmd "ip netns exec $ns2 sysctl -qw net.ipv4.fib_multipath_hash_policy=1"

	run_cmd "ip netns exec $ns2 sysctl -qw net.ipv4.conf.veth2.rp_filter=0"

	run_cmd "ip netns exec $ns2 sysctl -qw net.ipv4.conf.all.rp_filter=0"

	run_cmd "ip netns exec $ns2 sysctl -qw net.ipv4.conf.default.rp_filter=0"

	set +e



	local dmac=$(ip -n $ns2 -j link show dev veth2 | jq -r '.[]["address"]')

tools/testing/selftests/net/icmp_redirect.sh

+0 −2
Original line number Diff line number Diff line
@@ -178,8 +178,6 @@ setup() 
		else

			ip netns exec $ns sysctl -q -w net.ipv4.ip_forward=1

			ip netns exec $ns sysctl -q -w net.ipv4.conf.all.send_redirects=1

			ip netns exec $ns sysctl -q -w net.ipv4.conf.default.rp_filter=0

			ip netns exec $ns sysctl -q -w net.ipv4.conf.all.rp_filter=0



			ip netns exec $ns sysctl -q -w net.ipv6.conf.all.forwarding=1

			ip netns exec $ns sysctl -q -w net.ipv6.route.mtu_expires=10